Rename set and copy stencils #347
Conversation
|
cscs-ci run default |
|
cscs-ci run default |
|
cscs-ci run default |
|
launch jenkins spack |
|
launch jenkins icon iconProject=C2SM/cleanup_stencils |
|
cscs-ci run default |
|
launch jenkins spack |
|
launch jenkins icon iconProject=C2SM/cleanup_stencils |
|
launch jenkins icon iconProject=C2SM/cleanup_stencils |
1 similar comment
|
launch jenkins icon iconProject=C2SM/cleanup_stencils |
|
launch jenkins icon iconProject=C2SM/cleanup_stencils |
|
launch jenkins spack |
|
launch jenkins spack |
|
launch jenkins icon iconProject=C2SM/cleanup_stencils |
|
cscs-ci run default |
There was a problem hiding this comment.
It looks alright to me. I've first checked that you correctly deleted all the stencils you replaced and mentioned in the set/copy stencils. Second I've checked that the set/copy stencils correctly mirror the behaviour of the deleted stencils and finally that the stencil calls were replaced with the correct new name. I haven't checked whether these set/copy stencils could be used in other stencils that weren't touched. I trust you. Otherwise, that is what we can call a proper clean up, kudos!
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
|
cscs-ci run default |
|
launch jenkins spack |
This PR renames stencil that are setting fields or copying fields. These stencils are reused as much as possible.
This PR renames stencil that are setting fields or copying fields.
These stencils are reused as much as possible.